Capture insider transactor Name and tighten Date/FileDate types#8
Merged
AlexCatarino merged 1 commit intoMay 15, 2026
Merged
Conversation
QuiverQuant's live insiders endpoint returns a Name field for the transactor that wasn't being captured. Adds Name to QuiverInsiderTrading and QuiverInsiderTradingUniverse, stored between ownership and officer title in the CSV row. Reader now also falls back to uploadedDate (minus one day) when the on-disk Date column is empty, and Date/FileDate are non-nullable now that the parser always produces a value. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Namefield returned by Quiver'slive/insidersendpoint toQuiverInsiderTradingandQuiverInsiderTradingUniverse. Stored in the CSV row between ownership and officer title (position 10 in the per-ticker file, position 11 in the universe file).DateandFileDateare now non-nullable.Readerfalls back touploadedDate.AddDays(-1)when the on-disk Date column is empty, mirroring the existing FileDate fallback so the parser always yields a valid value.Test plan
Reader_ParsesCompactFormat,Reader_EmptyFileDateFallsBackToUploadedMinusOne,Reader_EmptyOptionalFieldsAreNull,UniverseReader_ParsesCompactFormat)Reader_EmptyDateFallsBackToUploadedMinusOnecovers the Date fallbackdotnet test— 15 / 15 pass